refactor: move domains to package core/{domain}#123
Merged
Conversation
Member
Author
|
converting this to draft as we need to test this manually first |
This was referenced Jul 22, 2022
Member
Author
|
This PR will also solve #125 |
krtkvrm
approved these changes
Jul 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR of some multiple tasks from this issue #121
Ideas
The structure would be layered like this
server(handler)/hook/middlewareshould talk to service layer to process dataChanges
modelto its own domainCheckPermission(ctx context.Context, usr user.User, resourceNS namespace.Namespace, resourceIdxa string, action action.Action) (bool, error)to avoid having dependency toresourcepackage.structspackageErrtest/integrationfolderv1.gotov1beta1.go