Skip to content

feat: remove delete button from actions dropdown menu for bulk removing#169

Merged
kmendell merged 1 commit intomainfrom
feat/action-buttons
May 12, 2025
Merged

feat: remove delete button from actions dropdown menu for bulk removing#169
kmendell merged 1 commit intomainfrom
feat/action-buttons

Conversation

@kmendell
Copy link
Member

@kmendell kmendell commented May 12, 2025

fixes: #130

Summary by CodeRabbit

  • New Features
    • Simplified bulk deletion actions for images, networks, and volumes by replacing dropdown menus with single "Delete Selected" buttons.
    • The new buttons clearly indicate loading and processing states during deletion.
  • Style
    • Improved interface clarity by removing dropdowns and presenting direct action buttons for bulk deletions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 12, 2025

📝 Walkthrough

Walkthrough

The changes remove dropdown menus for group actions on selected items (images, networks, volumes) in favor of a single, directly accessible "Delete Selected" button. The new button replaces the dropdown trigger and menu, maintains loading states with a spinner, and disables itself during processing. No changes were made to exported or public entities.

Changes

Files Change Summary
src/routes/images/+page.svelte Replaced group actions dropdown for selected images with a single "Delete Selected" button, preserving loading state.
src/routes/networks/+page.svelte Replaced group actions dropdown for selected networks with a single "Delete Selected" button, preserving loading state.
src/routes/volumes/+page.svelte Replaced group actions dropdown for selected volumes with a single "Delete Selected" button, preserving loading state.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Remove delete button from dropdown menu (#130)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/routes/images/+page.svelte

Oops! Something went wrong! :(

ESLint: 9.26.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)
(node:19207) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use node --trace-warnings ... to show where the warning was created)

src/routes/volumes/+page.svelte

Oops! Something went wrong! :(

ESLint: 9.26.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)
(node:19209) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use node --trace-warnings ... to show where the warning was created)

src/routes/networks/+page.svelte

Oops! Something went wrong! :(

ESLint: 9.26.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)
(node:19208) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use node --trace-warnings ... to show where the warning was created)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfeffd2 and 70a7fcb.

📒 Files selected for processing (3)
  • src/routes/images/+page.svelte (1 hunks)
  • src/routes/networks/+page.svelte (1 hunks)
  • src/routes/volumes/+page.svelte (1 hunks)
🔇 Additional comments (3)
src/routes/images/+page.svelte (1)

292-300: Clean implementation of the dedicated delete button.

The replacement of the dropdown menu with a direct "Delete Selected" button improves UI clarity and simplifies the user interaction. The implementation correctly handles loading states with a spinner and properly disables the button during processing.

src/routes/volumes/+page.svelte (1)

187-195: UI simplification looks good.

The dedicated destructive button provides a clearer path to action compared to the previous dropdown implementation. Loading states and button disabled status are handled appropriately.

src/routes/networks/+page.svelte (1)

215-223: Well-implemented UI consistency.

The direct "Delete Selected" button maintains consistency with the other resource pages. This change successfully meets the PR objective by removing the delete button from the actions dropdown menu while ensuring proper loading state handling.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kmendell kmendell merged commit cc15fae into main May 12, 2025
5 checks passed
@kmendell kmendell deleted the feat/action-buttons branch May 12, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Remove delete button from dropdown menu.

1 participant