fix: stack deployments for external networks

[kmendell]

Summary by CodeRabbit

• New Features

  • Action dialogs and button labels now use type-specific terminology: "Destroy"/"Down" for stacks and "Remove"/"Stop" for containers.
  • Stack actions now trigger immediate data refresh on the stack details page after completion.

• Improvements

  • Enhanced network configuration and error handling for stack operations.
  • More descriptive and consistent error messages during stack removal processes.

• Style

  • Updated input field heights on onboarding password and settings pages for a more consistent appearance.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This update introduces type-specific terminology and logic for stack versus container actions in the UI and backend services. API method names are updated for clarity. Stack removal logic is split into two distinct functions: one for full destruction and one for container-only removal. UI input styling is adjusted, and stack page actions now trigger data refreshes upon completion.

Changes

Files/Paths	Change Summary
src/lib/components/action-buttons.svelte	Updated confirmation dialogs, button labels, and API calls to differentiate between "stack" and "container" actions. Uses type-specific terminology ("Destroy"/"Down" for stacks, "Remove"/"Stop" for containers) and corresponding API methods. Pull action for stacks now directly calls the handler without confirmation.
src/lib/services/api/stack-api-service.ts	Renamed stop to down and remove to destroy in the StackAPIService class. Method logic and API endpoints remain unchanged.
src/lib/services/docker/stack-service.ts	Enhanced container network configuration and error handling in startStackWithExternalNetworks. Introduced User and DNS options in container config. Network assignment logic improved; unresolved network names now logged. Split and renamed stack removal logic: destroyStack (removes containers and stack files) and removeStack (removes containers only). Improved error handling and logging throughout.
src/routes/onboarding/password/+page.svelte, src/routes/onboarding/settings/+page.svelte	Changed input field styling classes from size-12 to h-12 to adjust input height for password, confirm password, Docker Host, and Polling Interval fields. No functional changes.
src/routes/stacks/[stackId]/+page.svelte	Added onActionComplete handler to the ActionButtons component to trigger invalidateAll() and refresh page data after stack actions complete. No other logic changes.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-18T23_17_02_778Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a1015da and a34dea3.

📒 Files selected for processing (6)

• src/lib/components/action-buttons.svelte (3 hunks)
• src/lib/services/api/stack-api-service.ts (2 hunks)
• src/lib/services/docker/stack-service.ts (3 hunks)
• src/routes/onboarding/password/+page.svelte (1 hunks)
• src/routes/onboarding/settings/+page.svelte (2 hunks)
• src/routes/stacks/[stackId]/+page.svelte (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.