Skip to content

Simplify switch cases with type assertion #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Simplify switch cases with type assertion #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions internal/jws/jws.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ func GenerateKeyPair() (sk, pk interface{}, err error) {
return nil, nil, fmt.Errorf("unknown signing algorithm '%s'", alg)
}
if err != nil {
switch sk.(type) {
switch sk := sk.(type) {
case *rsa.PrivateKey:
pk = &sk.(*rsa.PrivateKey).PublicKey
pk = &sk.PublicKey
case *ecdsa.PrivateKey:
pk = &sk.(*ecdsa.PrivateKey).PublicKey
pk = &sk.PublicKey
default:
err = fmt.Errorf("something went wrong, we just created an unknown key type")
}
Expand All @@ -51,11 +51,11 @@ func GenerateKeyPair() (sk, pk interface{}, err error) {

// ExportPrivateKeyAsPemStr exports the private key
func ExportPrivateKeyAsPemStr(sk interface{}) string {
switch sk.(type) {
switch sk := sk.(type) {
case *rsa.PrivateKey:
return exportRSAPrivateKeyAsPemStr(sk.(*rsa.PrivateKey))
return exportRSAPrivateKeyAsPemStr(sk)
case *ecdsa.PrivateKey:
return exportECPrivateKeyAsPemStr(sk.(*ecdsa.PrivateKey))
return exportECPrivateKeyAsPemStr(sk)
default:
return ""
}
Expand Down
4 changes: 2 additions & 2 deletions shared/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,9 @@ func StructToStringMap(st interface{}, tag string) map[string]string {
m := make(map[string]string)
for k, v := range s.Map() {
var str string
switch v.(type) {
switch v := v.(type) {
case string:
str = v.(string)
str = v
default:
str = fmt.Sprintf("%v", v)
}
Expand Down