Address dev friction with compare.html #2617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andychu
reviewed
Dec 16, 2025
Contributor
andychu
left a comment
andychu
left a comment
There was a problem hiding this comment.
This looks great, thank you!
Glad you were able to decipher my old awk scripts :-) This was "research" for the YSH language design
which I still want to do :-)
regtest/aports and test/spec-cpp both use what I call the "parallel process table pattern" -- with xargs
But I want YSH to have something nicer than xargs ! i.e. the patterns in these scripts are basically "YSH in crappy shell syntax" :-)
I'll mention this on Zulip
andychu
reviewed
Dec 16, 2025
last-genius
force-pushed
the
asv/friction-comparehtml
branch
from
f4a23a6 to
b5746e0
Compare
andychu
reviewed
Dec 17, 2025
Contributor
andychu
left a comment
andychu
left a comment
There was a problem hiding this comment.
I took a peek even though you didn't request review yet :-)
Contributor
|
Also it looks like the Docker registry is flaky now, so we can just restart the job https://github.com/oils-for-unix/oils/actions/runs/20310083784/job/58338811562 |
Adds two new columns to compare.html: cpp_num_failed and cpp_failures_allowed - these can show what went wrong with the job. Additionally, sets the background color of jobs with status!=0 to red to make the failure clearer. Fixes: #2615 Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
last-genius
force-pushed
the
asv/friction-comparehtml
branch
from
b5746e0 to
56cea52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compare.html not being generated for ysh-all on errors and makes it more informative so that it's clearer what caused the errors
Here's how osh-cpp's compare.html page looks like with this PR:
See https://op.oilshell.org/uuu/github-jobs/11017/cpp-spec.wwz/_tmp/spec/osh-cpp/compare.html for an example of "before", where it's unclear what the issue is.