Move history expansion to the parsing stage #2618
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
force-pushed
the
asv/history-expansion
branch
from
a0733c8 to
b847776
Compare
This is in preparation to moving history expansion to the parsing stage. Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
Split HistoryOp to four tokens to avoid inspecting the string in the parsing stage, move them into the Lit kind. Drop HISTORY_DEF, move tokens to _UNQUOTED. Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
…istory Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
This will change how the parser treats history expansion (!!), which is only handled in interactive shells. Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
It's quite primitive at the moment, just a proof of concept, and only implements !! + !num Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
last-genius
force-pushed
the
asv/history-expansion
branch
from
b847776 to
5c91a99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an early proof of concept while we are trying to figure out the details