[frontend] Cleanup in lexer_gen.py #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
last-genius
changed the title
Contributor
Author
|
not so sure about the second commit - might have been useful in debugging while strictly speaking it was commented out |
last-genius
changed the title
Contributor
|
Thanks, it's good to clean this up Except I think we should keep PrintTree() because it helps remind us what the internal structure of Python is ... it is a debugging function But yes the rest seems fine to delete. |
These are already defined above with the same values, there is no point definining them in each generated function as well. Signed-off-by: Andrii Sultanov <sultanovandriy@gmail.com>
last-genius
force-pushed
the
asv/lexer-gen
branch
from
d472f62 to
50d3dc7
Compare
Contributor
Author
Dropped this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.