Add exec -a flag to set argv[0] #2634
Merged
+17
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
issue |
Contributor
Author
|
Contributor
Author
|
@andychu review. |
andychu
reviewed
Jan 14, 2026
Contributor
andychu
left a comment
andychu
left a comment
There was a problem hiding this comment.
Thanks for adding this!
(sorry for the delayed review, usually I aim for 24 hours -- but I'm still busy with family stuff)
spec/builtin-process.test.sh
Outdated
| ## BUG mksh stdout-json: "" | ||
|
|
||
| #### exec -a sets argv[0] | ||
| exec -a FOOPROC /bin/bash -c 'echo $0' |
Contributor
There was a problem hiding this comment.
I would make this bash or better yet just sh because /bin/bash may not exist on every system
builtin/process_osh.py
Outdated
| c2_argv = [arg.a] | ||
| c2_argv.extend(cmd_val.argv[i+1:]) | ||
| else: | ||
| c2_argv = cmd_val.argv[i:] |
Contributor
There was a problem hiding this comment.
I think this would be simpler like:
argv = cmd_val.argv[i:]
if arg.a is not None:
argv[0] = arg.a
OK and actually I guess there is no way to change the location now ... but that's OK
exec -a foo python -c
^^^^^ # location is still python, not foo
Maybe write a comment about the location -- that controls this error
$ osh -c 'exec foo bar'
exec foo bar
^~~
[ -c flag ]:1: fatal: exec: 'foo' not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exec builtin now supports the -a flag to set argv[0], matching bash behavior.
close #2558