vs2017 warnings fix

akashche · akashche · commit f462fe8378a6 · 2020-05-25T03:14:18.000-07:00
diff --git a/src/fetchurl.cpp b/src/fetchurl.cpp
@@ -142,8 +142,8 @@ class AppliedHeaders {
         return headers.back();
     }
 
-    void set_slist(struct curl_slist* slist) {
-        this->slist = slist;
+    void set_slist(struct curl_slist* cslist) {
+        this->slist = cslist;
     }
 
 private:
diff --git a/src/notifier.cpp b/src/notifier.cpp
@@ -212,7 +212,11 @@ HRESULT CALLBACK link_clicked_callback(HWND hwnd, UINT uNotification, WPARAM /*
     }
     TRACER.trace("update proceed selected");
     HINSTANCE res = ShellExecuteW(NULL, NULL, reinterpret_cast<LPCTSTR> (lParam), NULL, NULL, SW_SHOW);
+#pragma warning(push)
+#pragma warning(disable : 4311) // 'reinterpret_cast': pointer truncation from 'HINSTANCE' to 'int'
+#pragma warning(disable : 4302) // 'reinterpret_cast': truncation from 'HINSTANCE' to 'int'
     int intres = reinterpret_cast<int> (res);
+#pragma warning(pop)
     bool success = intres > 32;
     if (!success) {
         TRACER.trace("'ShellExecuteW' fail, error: [" + ch::utils::to_string(intres) + "]");

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,8 @@ class AppliedHeaders {`
`142`	`142`	`return headers.back();`
`143`	`143`	`}`
`144`	`144`
`145`		`- void set_slist(struct curl_slist* slist) {`
`146`		`- this->slist = slist;`
	`145`	`+ void set_slist(struct curl_slist* cslist) {`
	`146`	`+ this->slist = cslist;`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`private:`