-
-
Notifications
You must be signed in to change notification settings - Fork 61
Fix fail_untyped for Dataclasses
#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fail_untyped for Dataclasses
#242
Conversation
mauvilsa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ioangatop thank you for the effort to contribute!
From what I see this pull request adds the fail_untyped parameter to add_dataclass_arguments. Indeed this is missing and it seems to resolve #241.
However, I see there is no unit test added. For every bug fix and new feature at least one unit test should be added, even if the coverage does not decrease with the code changes. Please convert the code snippet in the description #241 into a unit test.
@mauvilsa added! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@mauvilsa thank you very much for the review and merge! Question: because this feature is kinda important for us, do you know when you will tag a new version and release it? Thank you again |
|
To release I need to run further tests with projects where we use jsonargparse. I am currently traveling and unable to do that. I will try to look into it early next week. |








What does this PR do?
Closes #241
Before submitting