feat(cli)!: Make manifest create input files positional
#244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
added
type: feature
Member
Author
|
Ah, looks like the |
alilleybrinker
force-pushed
the
alilleybrinker/cli-multi-input
branch
from
1b58175 to
bbd9040
Compare
Member
Author
|
Hm, even after merging the |
This amends the `manifest create` arguments, turning the list of input files from a flag (`-i` / `--input`) into a positional argument. Normally I'm wary of positional arguments because they're less backwards compatible [1], but in this case this argument should always be the primary one, and making it positional makes it easier to integrate with things like shell subcommands to produce a file list. [1]: https://clig.dev/#arguments-and-flags Issue: #243 Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
alilleybrinker
force-pushed
the
alilleybrinker/cli-multi-input
branch
from
bbd9040 to
e9d27da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends the
manifest createarguments, turning the list of input files from a flag (-i/--input) into a positional argument. Normally I'm wary of positional arguments because they're less backwards compatible 1, but in this case this argument should always be the primary one, and making it positional makes it easier to integrate with things like shell subcommands to produce a file list.Closes #243