-
-
Notifications
You must be signed in to change notification settings - Fork 0
Dashboard Mutations #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobbescodes
commented
Jan 3, 2025
hobbescodes
commented
Jan 4, 2025
coopbri
reviewed
Jan 8, 2025
Co-authored-by: Brian Cooper <20056195+coopbri@users.noreply.github.com>
coopbri
reviewed
Jan 8, 2025
coopbri
reviewed
Jan 8, 2025
coopbri
reviewed
Jan 8, 2025
src/components/organization/CreateOrganization/CreateOrganization.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Brian Cooper <20056195+coopbri@users.noreply.github.com>
coopbri
reviewed
Jan 8, 2025
hobbescodes
commented
Jan 8, 2025
coopbri
reviewed
Jan 10, 2025
coopbri
reviewed
Jan 10, 2025
coopbri
reviewed
Jan 10, 2025
coopbri
reviewed
Jan 10, 2025
coopbri
reviewed
Jan 10, 2025
coopbri
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Task link: https://linear.app/omnidev/issue/OMNI-128/dashboard-mutations
Added functionality for creating a new project, as well as creating a new organization when the organizations overview is in an empty state, to the dashboard page. This PR must be tested in coordination with the adjustments made to the API outlined in this PR.
Additional Tasks:
Note
You will notice that the patterns designed within this PR do not use server side validation / form submission. Happy to adjust accordingly if that is the route we wish to take, I just figured that with using RQ, we will generally want to manipulate the cache directly upon mutations for optimistic updates, so I think the
useMutationroute in our case is a better pattern. But definitely open to discuss / adjusting! Context on server side form validation and submission with tanstack form can be found here.Test Steps