Unable to get geolocation demo app to work (Android)

[nickw1]

Steps to Reproduce

1. Clone repo, add a fake lat and lon to the geolocation example app, and build
2. Serve the built geolocation example app with an HTTP server from the build directory

OR

1. Build the geolocation example app (with fake lat/lon) as a standalone app, by installing @omnidotdev/rdk version 0.2 from NPM.

OR

Either of the above in dev mode.

Expected Behavior

Demo should have worked.

Actual Behavior

Both methods produce the same result, this error occurs:

Internal error: no requestPermission() found although requestOrientationPermissions() was called - please raise an issue on GitHub (code LOCAR_DEVICE_ORIENTATION_INTERNAL_ERROR)

This is an error from LocAR.js related to requesting permissions. It's only supposed to be called on iOS (once the initial gesture has been made by the user) but is being called on Android. This error does not occur with standalone LocAR.js.

Environment

Android 13 on a Pixel 3, testing via the Chrome Developer Tools on a host Linux machine.
Using bun and vite

Additional Notes/Screenshots

I'm the main developer of LocAR.js as you know, but just wonder if it works for you. If there is a bug I am happy to help fix.

[nickw1]

@coopbri I have seen the bug. The problem is that in geolocationBackend.ts, requestOrientationPermissions() is always called but requestPermission() only exists in iOS.

In fact the try/catch from lines 75 to 86 is unnecessary: if you call DeviceOrientationControls.init() the permission handling is triggered.

Let me try to fix this and test it to see if it works, if so I will submit a PR.

[coopbri]

Thanks Nick, the demo works for me on Chrome Pixel 9, Android 16. I have an older Android I will try to repro with, but you're right about the code improvements in comment above in any case 👍 Appreciate you digging in and I'll do the same this week!

[nickw1]

Hello Brian, no worries! I've found that the above does indeed prevent the error from occurring. I'm guessing that on your environment the window.DeviceOrientationEvent.requestPermission API exists, the error will occur if this is not present.

I don't see the anchors, however, but that seems to be a separate issue related to when fakeGps() fires and I'll create a separate issue for that.

Will submit a PR with the above try/catch commented out.

[coopbri]

Closed by #17