Conversation
isaevil
force-pushed
the
dev/isaevil/fix_coverage
branch
from
b3d83c0 to
b156879
Compare
isaevil
force-pushed
the
dev/isaevil/fix_coverage
branch
from
b156879 to
18db72e
Compare
AlexVeprev
reviewed
Jul 31, 2021
Contributor
|
Please provide the motivation for new options in the description. |
Signed-off-by: Ilya Isaev <ilya.isaev@intel.com>
Signed-off-by: Ilya Isaev ilya.isaev@intel.com Co-authored-by: Alexey Veprev <alexey.veprev@intel.com>
Signed-off-by: Ilya Isaev <ilya.isaev@intel.com>
isaevil
force-pushed
the
dev/isaevil/fix_coverage
branch
from
27907dd to
c7e36e4
Compare
AlexVeprev
approved these changes
Aug 2, 2021
| endif() | ||
| if (APPLE) | ||
| message(STATUS "TBBBind build targets are disabled due to unsupported environment") | ||
| else() |
Contributor
There was a problem hiding this comment.
There is add_subdirectory(src/tbbbind) one line below.
We've discussed that normally tbbbind is skipped due to lack of hwloc paths, but take into account auto-detection of hwloc using pkg-config: https://github.com/oneapi-src/oneTBB/blob/357c9b27fa84eaf748bc556585c26995c446eceb/cmake/hwloc_detection.cmake#L53
User still can force disabling hwloc detection through TBB_DISABLE_HWLOC_AUTOMATIC_SEARCH. It's just FYI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scope of this patch
TBB_BUILDandTBBMALLOC_BUILDoptions were added. It was done to support scenarios when we are testing without tbbmalloc. It allows us to cover place where we fail to link with tbbmalloc and start usingstd_cache_aligned_allocate/deallocate.Signed-off-by: Ilya Isaev ilya.isaev@intel.com