Skip to content

Unify compilation flags in CMake #944

@KFilipek

Description

@KFilipek

Some flags overlaps with -Wall, -Wextra, -Wpedantic. They should be reworked and some of them are marked below.

                    -fPIC 
                    -Wall
                    -Wextra
                    -Wpedantic
                    -Wempty-body // enabled by: -Wextra
                    -Wunused-parameter // enabled by: -Wextra
                    -Wformat // enabled by: -Wall and set to 1 (-Wformat=1)
                    -Wformat-security
                    -Wcast-qual
                    -Wunused-result // Enabled by default, to use this feature there should be annotation in code, e.g.: __attribute__ ((warn_unused_result))

To see what parameters overlap look at the https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

Environment Information

  • UMF version (hash commit or a tag):
  • OS(es) version(s):
  • kernel version(s):
  • compiler, libraries, and other related tools version(s):

Please provide a reproduction of the bug:

How often bug is revealed:

(always, often, rare)

Actual behavior:

Expected behavior:

Details

Additional information about Priority and Help Requested:

Are you willing to submit a pull request with a proposed change? (Yes, No)

Requested priority: (Showstopper, High, Medium, Low)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions