Skip to content

Conversation

@JackAKirk
Copy link
Contributor

@JackAKirk JackAKirk commented Jun 26, 2024

Add UR_DEVICE_INFO_CLUSTER_LAUNCH_EXP to the launch property extension.

One of the launch properties is not supported on all devices so requires an aspect.
This aspect returns true only for sm_90 cuda gpus.

This will be tested via a intel/llvm PR shortly.

@JackAKirk JackAKirk requested review from a team as code owners June 26, 2024 17:17
@JackAKirk JackAKirk requested a review from ldrumm June 26, 2024 17:17
@github-actions github-actions bot added conformance Conformance test suite issues. specification Changes or additions to the specification experimental Experimental feature additions/changes/specification cuda CUDA adapter specific issues labels Jun 26, 2024
this aspect is true only for sm_90 cuda gpus.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk changed the title [cuda][ext] Add cluster_launch device aspect. [cuda][ext] Add UR_DEVICE_INFO_CLUSTER_LAUNCH_EXP Jun 26, 2024
@JackAKirk
Copy link
Contributor Author

This was additionally tested via intel/llvm#14113 with the corresponding tests passing in its last ci run via intel/llvm@0380732#diff-9c95510e2865ef6a7b6d9213eb51a4ce17f141fe884959eeec497ac58e5bdfdf
But the ur part is also tested by the updated ur test made in this PR.

@JackAKirk JackAKirk added the ready to merge Added to PR's which are ready to merge label Jun 27, 2024
@JackAKirk JackAKirk changed the title [cuda][ext] Add UR_DEVICE_INFO_CLUSTER_LAUNCH_EXP [EXP][CUDA] Add UR_DEVICE_INFO_CLUSTER_LAUNCH_EXP Jun 28, 2024
@hdelan hdelan mentioned this pull request Jun 28, 2024
@callumfare
Copy link
Contributor

This was included in #1804 which has now merged

@callumfare callumfare closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants