Always use translated command-lists #1831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
EwanC
approved these changes
Jul 9, 2024
Contributor
EwanC
approved these changes
Jul 11, 2024
pbalcer
reviewed
Jul 12, 2024
nrspruit
reviewed
Jul 30, 2024
| auto Platform = CommandBuffer->Context->getPlatform(); | ||
| ZE2UR_CALL( | ||
| Platform->ZeMutableCmdListExt.zexCommandListUpdateMutableCommandsExp, | ||
| (CommandBuffer->ZeComputeCommandListTranslated, &MutableCommandDesc)); |
Contributor
There was a problem hiding this comment.
You still need the translated compute command list handle. Any call to an extension function pointer requires all handles used are translated.
nrspruit
reviewed
Jul 30, 2024
| &ZeMutableCommandDesc, &CommandId)); | ||
| ZE2UR_CALL( | ||
| Platform->ZeMutableCmdListExt.zexCommandListGetNextCommandIdExp, | ||
| (CommandBuffer->ZeComputeCommandList, &ZeMutableCommandDesc, &CommandId)); |
Contributor
There was a problem hiding this comment.
This will fail, you need to translate both handles, not just the copy above. This will break the code.
nrspruit
requested changes
Jul 30, 2024
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
This is incorrect, translated handles can only be used on EXP function pointers retrieved from the driver, they will cause segfaults if used on normal apis and one is running with multiple drivers.
Contributor
Author
|
Closing due to review feedback mentioning that this won't work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the implementation of command-buffers to use translated command-list handles in every API call instead of only using them for experimental L0 API's. This avoids having to keep track of 2 separate command-list handles which can be confusing.