Skip to content

Improvements to align CTS and Spec for Memory #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Improvements to align CTS and Spec for Memory #2177

wants to merge 5 commits into from

Conversation

@martygrant
Copy link
Contributor

@martygrant martygrant commented Oct 7, 2024

  • Add test for expecting UR_RESULT_ERROR_INVALID_NULL/HOST_POINTER for urMemImageCreate and urMemBufferCreate
  • Add more checks for UR_RESULT_ERROR_INVALID_IMAGE_FORMAT_DESCRIPTOR for urMemImageCreate
  • Added missing error condition to spec for urMemImageCreate - UR_STRUCTURE_TYPE_IMAGE_DESC != pImageDesc->stype
  • Add tests for expecting UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urMemBuffer/ImageCreateWithNativeHandle
  • Remove skip for urMemImageCreateWithNativeHandle - buffer was invalid, creating it in the test fixture definition now
  • Update image format used in urMemImageText fixture as it was invalid and would cause previously skipped tests to fail (they now pass)
  • Fix DDI table entry for urMemImageCreateWithNativeHandle for OpenCL
  • Add test for calling urMemBufferPartition with different ur_mem_flag_t flags
  • Add missing UR_MEM_INFO_REFERENCE_COUNT to spec for urMemGetInfo. Added a test for this and checking ref count is updated in urMemRetain/Release

@martygrant martygrant requested review from a team as code owners October 7, 2024 11:10
@martygrant martygrant requested a review from hdelan October 7, 2024 11:10
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues labels Oct 7, 2024
@martygrant martygrant mentioned this pull request Oct 7, 2024
Merged
RossBrunton
RossBrunton reviewed Oct 7, 2024
View reviewed changes
@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch from 3d8e586 to 44a3af6 Compare October 7, 2024 15:23
@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch 2 times, most recently from 6b05f8d to 4019c6b Compare October 7, 2024 15:51
hdelan
hdelan approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo. Otherwise LGTM

@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch 2 times, most recently from c87aa26 to f3225db Compare October 9, 2024 11:45
@martygrant martygrant requested a review from a team as a code owner October 9, 2024 11:45
@github-actions github-actions bot added the native-cpu Native CPU adapter specific issues label Oct 9, 2024
PietroGhg
PietroGhg approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU lgtm, thank you

@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch 6 times, most recently from 6ebc453 to 6d413eb Compare October 10, 2024 08:25
@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch 7 times, most recently from 1270f94 to f911dab Compare October 11, 2024 17:18
@martygrant
Improvements to align CTS and Spec for Memory:
ea0d67f 
	- Add test for expecting UR_RESULT_ERROR_INVALID_NULL/HOST_POINTER for urMemImageCreate and urMemBufferCreate
	- Add more checks for UR_RESULT_ERROR_INVALID_IMAGE_FORMAT_DESCRIPTOR for urMemImageCreate
	- Added missing error condition to spec for urMemImageCreate - UR_STRUCTURE_TYPE_IMAGE_DESC != pImageDesc->stype
	- Add tests for expecting UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urMemBuffer/ImageCreateWithNativeHandle
	- Remove skip for urMemImageCreateWithNativeHandle - buffer was invalid, creating it in the test fixture definition now
	- Update image format used in urMemImageText fixture as it was invalid and would cause previously skipped tests to fail (they now pass)
	- Fix DDI table entry for urMemImageCreateWithNativeHandle for OpenCL
	- Add test for calling urMemBufferPartition with different ur_mem_flag_t flags
	- Add missing UR_MEM_INFO_REFERENCE_COUNT to spec for urMemGetInfo. Added a test for this and checking ref count is updated in urMemRetain/Release
@martygrant martygrant marked this pull request as draft October 14, 2024 14:52
@martygrant martygrant force-pushed the martin/memory-cts-spec-gap branch from f911dab to 3790b8f Compare October 14, 2024 14:53
@martygrant martygrant mentioned this pull request Oct 24, 2024
Merged
@martygrant martygrant closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@RossBrunton RossBrunton RossBrunton approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

@hdelan hdelan hdelan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@martygrant @RossBrunton @PietroGhg @hdelan