Skip to content

[UR] Initial spec for the enqueue allocation API #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[UR] Initial spec for the enqueue allocation API #2295

wants to merge 1 commit into from

Conversation

@kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Nov 7, 2024

Those changes are based on the initial PR (#2180) with minor changes, wording and CI testing fixes.

@kswiecicki kswiecicki requested review from igchor and pbalcer November 7, 2024 12:55
@github-actions github-actions bot added loader Loader related feature/bug common Changes or additions to common utilities specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues labels Nov 7, 2024
@kswiecicki kswiecicki marked this pull request as ready for review November 12, 2024 13:17
@kswiecicki kswiecicki requested review from a team as code owners November 12, 2024 13:17
@kswiecicki kswiecicki requested a review from Seanst98 November 12, 2024 13:17
@kswiecicki kswiecicki force-pushed the async-spec branch 2 times, most recently from 2ba7bc6 to bc9d8a4 Compare November 19, 2024 12:11
@kswiecicki kswiecicki mentioned this pull request Nov 19, 2024
Closed
@github-actions github-actions bot added the opencl OpenCL adapter specific issues label Nov 22, 2024
@kswiecicki
Copy link
Contributor Author

kswiecicki commented Nov 25, 2024

@oneapi-src/unified-runtime-native-cpu-write, @oneapi-src/unified-runtime-opencl-write, @oneapi-src/unified-runtime-hip-write, @oneapi-src/unified-runtime-cuda-write, @oneapi-src/unified-runtime-level-zero-write.
Changes in the respective adapters are minimal, containing only the placeholder function definitions that return NOT_SUPPORTED and serve as stubs for future implementation.

aarongreig
aarongreig approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@aarongreig aarongreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of typos

scripts/core/EXP-ASYNC-ALLOC.rst Outdated
UR command enqueues without forcing synchronization points in the asynchronous
command DAG associated with a queue. This can allow applications to compose
memory allocation and command execution asynchronously, which can improve
performancet.
Copy link
Contributor

@aarongreig aarongreig Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
performancet.
performance.

Copy link
Contributor Author

@kswiecicki kswiecicki Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've fixed the typos.

scripts/core/exp-async-alloc.yml Outdated
name: hQueue
desc: "[in] handle of the queue object"
- type: $x_usm_pool_handle_t
desc: "[in][optional] handle of the USM memory pooliptor"
Copy link
Contributor

@aarongreig aarongreig Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
desc: "[in][optional] handle of the USM memory pooliptor"
desc: "[in][optional] handle of the USM memory pool"

Copy link
Contributor Author

@kswiecicki kswiecicki Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

igchor
igchor reviewed Nov 25, 2024
View reviewed changes
@kswiecicki kswiecicki requested review from a team and removed request for a team December 2, 2024 13:03
@hdelan hdelan mentioned this pull request Dec 10, 2024
Closed
@hdelan
Copy link
Contributor

hdelan commented Dec 10, 2024

These spec changes taken from this PR are still in flight and up for discussion. Further spec changes may be necessary. I would suggest holding off merging this PR until the spec is finalized.

@github-actions github-actions bot added the conformance Conformance test suite issues. label Jan 21, 2025
@kswiecicki kswiecicki force-pushed the async-spec branch 3 times, most recently from 15968d5 to 562ef3e Compare January 29, 2025 12:38
@kswiecicki kswiecicki mentioned this pull request Jan 31, 2025
Closed
@kswiecicki
Add initial spec for async alloc entry points
9317705 
First basic work in progress spec.
@martygrant
Copy link
Contributor

martygrant commented Feb 20, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.

This is an automated comment.

@martygrant
Copy link
Contributor

martygrant commented Feb 28, 2025

Unified Runtime -> intel/llvm Repo Move Notice

Following on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm.

This PR has now been marked with the auto-close label and will be automatically closed after 30 days.

Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm.

Should there be a reason for this PR to remain open, manually remove the auto-close label.

This is an automated comment.

@github-actions github-actions bot closed this Mar 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Automatic PR Closure Notice

Information

This PR has been closed automatically. It was marked with the auto-close label 30 days ago as part of the Unified Runtime source code migration to the intel/llvm repository - intel/llvm#17043.

All Unified Runtime development should be done in intel/llvm, details can be found in the updated contribution guide.
This repository will continue to exist as a mirror and will host the specification documentation.

Next Steps

Should you wish to re-open this PR it must be moved to intel/llvm. We have provided a script to help automate this process, otherwise no actions are required.

This is an automated comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

@Seanst98 Seanst98 Awaiting requested review from Seanst98 Seanst98 was automatically assigned from oneapi-src/unified-runtime-hip-write

+4 more reviewers

@igchor igchor igchor left review comments

@aarongreig aarongreig aarongreig approved these changes

@omarahmed1111 omarahmed1111 omarahmed1111 approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-close common Changes or additions to common utilities conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kswiecicki @hdelan @martygrant @pbalcer @aarongreig @igchor @omarahmed1111 @PietroGhg