Improvements to align CTS and Spec for Device #2486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-query Add UR_ADAPTER_INFO_VERSION query
The new `UUR_KNOWN_FAILURE_ON` macro can be used to skip tests on
devices where the test is known to fail. This can be done in the
following situations.
For all devices in an adapter:
```cpp
UUR_KNOWN_FAILURE_ON(uur::LevelZero{});
```
By substring match of the device name within and adapter:
```cpp
UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"});
```
> Note: This invocation is used in a few places in this patch to
> facilitate clean runs when using this decice.
In certain test suits, where there is no access to a device, the
platform name is used instead:
```cpp
UUR_KNOWN_FAILURE_ON(uur::CUDA{"NVIDIA CUDA BACKEND"});
```
When neither device or platform is available in a test suite, the name
is ignored and only the adapter backend is used to determine if the test
is a known failure.
The macro is variadic making it possible to specify known failures for
multiple adapters in a single place and multiple names can also be provided
per adapter:
```cpp
UUR_KNOWN_FAILURE_ON(
uur::OpenCL{
"Intel(R) UHD Graphics 750",
"Intel(R) UHD Graphics 770",
},
uur::HIP{"Radeon RX 7700"},
uur::NativeCPU{});
```
There are a couple left over: Where fails were specific to cfi config these will need to wait for a compile def so the KNOWN_FAILs can be ifdef'd The hip usm pool match entries just seem wrong, hip does have pool support so at least the basic pool tests should be passing. Suspect out of date match file, CI testing will validate
There are a couple left over: Where fails were specific to cfi config these will need to wait for a compile def so the KNOWN_FAILs can be ifdef'd The hip usm pool match entries just seem wrong, hip does have pool support so at least the basic pool tests should be passing. Suspect out of date match file, CI testing will validate
- Rework urDeviceGetInfoTest to move all enums to their own tests instead of a switch case (oneapi-src#2290) - Remove the UR/OpenCL enum map function - no point maintaining both a switch case and a separate mapping function - Update some spec wording for consistency - Add missing info enums to OpenCL adapater - Add new urDevicePartition test for checking UR_DEVICE_INFO_PARENT_DEVICE - Move UUR_RETURN_ON_FATAL_FAILURE and UUR_ASSERT_SUCCESS_OR_UNSUPPORTED to join similar macros in checks.h
martygrant
force-pushed
the
martin/device-cts-spec-gap
branch
from
a2bc1b8 to
e3f06b9
Compare
14 tasks
github-actions
bot
added
ci/cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.