Add ur_program_properties_t for program creation #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
reviewed
Feb 16, 2023
kbenzie
force-pushed
the
benie/program-metadata
branch
from
d5daec5 to
3b923d8
Compare
martygrant
approved these changes
Feb 17, 2023
kbenzie
force-pushed
the
benie/program-metadata
branch
from
3b923d8 to
967c56d
Compare
kbenzie
force-pushed
the
benie/program-metadata
branch
from
967c56d to
f9927a0
Compare
pbalcer
approved these changes
Feb 20, 2023
The new `ur_program_properties_t` struct allows the provision of additional metadata to be passed into the `urProgramCreate`/`urProgramCreateWithBinary` entry points. Additionally, it supports `stype` and `pNext` which enable extending program creation without breaking ABI. Fixes oneapi-src#95
kbenzie
force-pushed
the
benie/program-metadata
branch
from
f9927a0 to
f1732b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
ur_program_properties_tstruct allows the provision ofadditional metadata to be passed into the
urProgramCreate/urProgramCreateWithBinaryentry points.Additionally, it supports
stypeandpNextwhich enable extendingprogram creation without breaking ABI.
Fixes #95