[ur] Replace extern logger object with a singleton #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbalcer
reviewed
Mar 10, 2023
source/common/logger/ur_sinks.hpp
Outdated
| template <typename... Args> | ||
| void log(logger::Level level, const char *fmt, Args &&...args) { | ||
| *ostream << "<" << logger_name << ">"; | ||
| *ostream << "[" << level_to_str(level) << "]:"; |
Contributor
There was a problem hiding this comment.
I think there should be a space after :
PatKamin
force-pushed
the
logger-singleton
branch
from
07f40c2 to
99e6a95
Compare
PatKamin
force-pushed
the
logger-singleton
branch
from
99e6a95 to
29028ac
Compare
pbalcer
reviewed
Mar 13, 2023
source/common/logger/ur_logger.hpp
Outdated
|
|
||
| Logger create_logger(std::string logger_name); | ||
|
|
||
| inline Logger &get_logger(std::string name = "") { |
Contributor
There was a problem hiding this comment.
This means that tests and other places you log without explicit init will print <>[INFO]: message. Maybe instead we can use 'common' ?
PatKamin
force-pushed
the
logger-singleton
branch
2 times, most recently
from
b4eecd2 to
54edea0
Compare
Replace extern logger object with a singleton one. Remove the need for initializing logger when logger is not used. Add printing logger name at the beginning of messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace extern logger object with a singleton one. Remove the need for initializing logger when logger is not used.
Add printing logger name at the beginning of messages.