Fix source inspector editor path resolution

Author: natew

packages/one/src/vite/plugins/sourceInspectorPlugin.test.ts

@@ -0,0 +1,40 @@
+import { describe, expect, it } from 'vitest'
+
+import { getSourceInspectorPath, resolveEditorFilePath } from './sourceInspectorPlugin'
+
+describe('sourceInspectorPlugin helpers', () => {
+  describe('getSourceInspectorPath', () => {
+    it('keeps project files relative to the current cwd', () => {
+      expect(getSourceInspectorPath('/repo/packages/one/src/App.tsx', '/repo')).toBe(
+        '/packages/one/src/App.tsx'
+      )
+    })
+
+    it('does not strip matching path prefixes from files outside cwd', () => {
+      expect(
+        getSourceInspectorPath('/repo-other/packages/one/src/App.tsx', '/repo')
+      ).toBe('/repo-other/packages/one/src/App.tsx')
+    })
+  })
+
+  describe('resolveEditorFilePath', () => {
+    it('resolves project-relative source paths against cwd', () => {
+      const fileExists = (filePath: string) =>
+        filePath === '/repo/packages/one/src/App.tsx'
+
+      expect(
+        resolveEditorFilePath('/packages/one/src/App.tsx', '/repo', fileExists)
+      ).toBe('/repo/packages/one/src/App.tsx')
+    })
+
+    it('preserves absolute source paths for files outside cwd', () => {
+      expect(
+        resolveEditorFilePath(
+          '/Users/n8/shared/ui/Button.tsx',
+          '/repo/apps/site',
+          () => false
+        )
+      ).toBe('/Users/n8/shared/ui/Button.tsx')
+    })
+  })
+})

packages/one/src/vite/plugins/sourceInspectorPlugin.ts

@@ -1,4 +1,5 @@
 import { spawn } from 'node:child_process'
+import { existsSync } from 'node:fs'
 import path from 'node:path'
 import { parse } from 'oxc-parser'
 import type { Plugin, ViteDevServer } from 'vite'
@@ -91,14 +92,41 @@ async function findJsxElements(code: string, filename: string): Promise<JsxLocat
 
 type TransformOut = { code: string; map?: null } | undefined
 
+export function getSourceInspectorPath(filePath: string, cwd = process.cwd()): string {
+  const normalizedFilePath = normalizePath(filePath)
+  const normalizedCwd = normalizePath(cwd)
+
+  if (normalizedFilePath === normalizedCwd) {
+    return '/'
+  }
+
+  if (normalizedFilePath.startsWith(`${normalizedCwd}/`)) {
+    return normalizedFilePath.slice(normalizedCwd.length)
+  }
+
+  return normalizedFilePath
+}
+
+export function resolveEditorFilePath(
+  filePath: string,
+  cwd = process.cwd(),
+  fileExists: (path: string) => boolean = existsSync
+): string {
+  const projectPath = path.join(cwd, filePath)
+
+  // data-one-source uses "/foo.tsx" for project-relative paths, but files outside
+  // cwd are stored as absolute paths and must not be re-joined onto cwd.
+  return fileExists(projectPath) ? projectPath : filePath
+}
+
 /**
  * Transforms JSX to inject data-one-source attributes using oxc-parser.
  */
 async function injectSourceToJsx(code: string, id: string): Promise<TransformOut> {
   const [filePath] = id.split('?')
   if (!filePath) return
 
-  const location = filePath.replace(normalizePath(process.cwd()), '')
+  const location = getSourceInspectorPath(filePath)
 
   // Quick check - skip if no JSX-like content
   if (!code.includes('<') || !code.includes('>')) {
@@ -159,7 +187,7 @@ function openInEditor(
     return
   }
 
-  const fullPath = path.join(process.cwd(), filePath)
+  const fullPath = resolveEditorFilePath(filePath)
   const l = line || '1'
   const c = column || '1'
   const buildArgs = editorArgs[resolved]

tests/test-skew-protection/app/crash+spa.tsx

@@ -19,7 +19,7 @@ export default function Crash() {
     if (type === 'chunk') {
       // matches the chrome chunk-load message in CHUNK_ERROR_PATTERNS
       throw new Error(
-        "Failed to fetch dynamically imported module: https://example.com/assets/foo-abc123.js"
+        'Failed to fetch dynamically imported module: https://example.com/assets/foo-abc123.js'
       )
     }
     if (type === 'other') {