fix(report): adapt landlock passthrough for report file #1127
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report writing only worked if the report was being written to a child location of the extract directory. This was a byproduct of setting rw permissions on the extraction directory. It did not work when the report file was being written to a location that is unrelated to the extraction directory. Fixed by requesting rw access to the report's file parent directory. I tried to get smart by only allowing make_reg and read_write on the file, but it never fully worked because of file truncation and the fact that LANDLOCK_ACCESS_FS_TRUNCATE is only available since ABI version 3 in landlock.
qkaiser
force-pushed
the
1101-report-file-sandboxing
branch
from
a9c9bce to
a8efa93
Compare
vlaci
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report writing only worked if the report was being written to a child location of the extract directory. This was a byproduct of setting rw permissions on the extraction directory.
It did not work when the report file was being written to a location that is unrelated to the extraction directory.
Fixed by requesting rw access to the report's file parent directory.
I tried to get smart by only allowing make_reg and read_write on the file, but it never fully worked because of file truncation and the fact that LANDLOCK_ACCESS_FS_TRUNCATE is only available since ABI version 3 in landlock.
Solves #1101