chore(deps): Downgrade 7zip to v16.02 in nix packaging #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
reviewed
Apr 13, 2025
Contributor
qkaiser
left a comment
qkaiser
left a comment
There was a problem hiding this comment.
LGTM. However, I would like the commit to describe what those problems are.
Found some problems with 7z based extractions using the nix environment
which does not happen in debian.
Is the extraction different ? Did options changed ?
Found some problems with 7z based extractions using the nix environment
which does not happen in debian. The reason is that debian still using a
quite old stable version of the 7z, while a newer one is coming from
nixpkgs.
This commit downgrades 7zip version used by unblob's nix packaging to the same
version (applying the same patches) as debian does, hopefully making the
extractors more stable using nix-based environment.
7zip maintainers changed the behavior or MBR extraction between version
16.02 and 17.05:
- on 16.02, 7z creates a file per MBR partition in the extraction
directory, regardless of the amount of partitions. So we get these
files named ("0.img", "1.img") after their partition entry ID.
- on 17.05, 7z will automagically extract the partition itself if there
is a single partition within the MBR and that partition is a supported
filesystem format (e.g. extfs). So instead of having a "0.img" file,
you immediately get the content of that partition written to disk.
Since one of the main objective of unblob is to identify known/unknown
chunks and provide detailed meta-data about them, we consider important
to have that intermediate step provided by 16.02. This way we know the
MRB contains a partition of a specific type, which itself was handled by
a dedicated unblob handler.
This behavior is kind of invisible on unblob-core since the MBR handler
is only available on the ONEKEY platform right now.
7z 17.05 also has issues when extracting ZIP files, where it does not
accept full path for the "-o" option. For example, "-o/tmp/lol" won't
work, but "cd /tmp/lol; 7z x -p -y sample.zip -o." will. On top of that,
7z seems to set arbitrary permissions on the output directory.
qkaiser
approved these changes
Apr 14, 2025
Contributor
Investigated and edited the commit message: |
Contributor
|
Also worth mentioning that Debian and RHEL are both sticking to 16.02 as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.