internal API: ensure that ExtractConfig.extract_root is an absolute path #389
+18
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3krisztian
force-pushed
the
internal-extract-root-must-be-absolute-path
branch
from
f5e1ff4 to
223b06f
Compare
e3krisztian
changed the title
…path ExtractConfig.extract_root must be an absolute path, as a relative path would result in a wrong, very flat extraction output layout.
e3krisztian
force-pushed
the
internal-extract-root-must-be-absolute-path
branch
from
223b06f to
f0de272
Compare
kissgyorgy
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.