Add ZSTD compression format #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qkaiser
force-pushed
the
feat-zstd-format
branch
3 times, most recently
from
da41d54 to
671a180
Compare
martonilles
requested changes
Jun 9, 2022
Contributor
martonilles
left a comment
martonilles
left a comment
There was a problem hiding this comment.
I would consider not decompressing the content in the handler, rather just iterate over the block, which should be significantly faster.
qkaiser
force-pushed
the
feat-zstd-format
branch
2 times, most recently
from
fbc54e6 to
37def37
Compare
martonilles
requested changes
Jun 14, 2022
Support is provided by the zstandard library recommended by ZSTD format maintainers (see https://python-zstandard.readthedocs.io/en/latest/decompressor.html). The implementation is similar to the one we got for gzip, execpt we did not have to monkeypatch it this time. More information about ZSTD can be found at https://github.com/facebook/zstd/blob/dev/doc/zstd_compression_format.md
qkaiser
force-pushed
the
feat-zstd-format
branch
from
37def37 to
786cc66
Compare
martonilles
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support is provided by the zstandard library recommended by ZSTD format maintainers (see https://python-zstandard.readthedocs.io/en/latest/decompressor.html).
The implementation is similar to the one we got for gzip, except we did not have to monkeypatch it this time.
More information about ZSTD can be found at https://github.com/facebook/zstd/blob/dev/doc/zstd_compression_format.md