Explicitly set LIEF logging level. #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't see any logs defined with critical severity in lief so this change effectively disables logging too. |
Contributor
maybe set tot ERROR level? |
We don't want informational logs polluting unblob logs, but we do want to be informed when something really wrong happened so instead of completely disabling LIEF logging, we set the level to ERROR. Fixes #391
qkaiser
force-pushed
the
391-fix-lief-logs
branch
from
8b65ed2 to
2d49a02
Compare
Contributor
Author
|
Set to ERROR level and edited the commit message accordingly. Double checked that log pollution does not happen with ERROR level. |
vlaci
approved these changes
Jun 9, 2022
Contributor
|
If we later find that we'd need these logs in the python logger, it doesn't seem that hard to improve LIEF's Python binding to swap the logger to a wrapper to Python's logging library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want informational logs from LIEF polluting unblob logs, but we do want to be informed when something really wrong happened so instead of completely disabling LIEF logging, we set the level to CRITICAL.
Fixes #391