Remove magic_file config option
#404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced this API to be able to use it ourselves, but as it turns out we don't need it, and we don't want to expose a public API unnecessarily, because we can never "take it back". Also the `MAGIC` environment variable works well for libmagic if someone wants to control the magic database, so this API might not even be needed. The problem we were trying to solve to use the same magic database on different systems, but that turned out impossible to do, because the magic database format breaks between every version, so the only way to use libmagic is to use the same version of the magic database, which is usually the one shipped with the system.
kissgyorgy
force-pushed
the
revert-magic-api
branch
from
e649209 to
620cadd
Compare
kissgyorgy
changed the title
magic_file config option
vlaci
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced this API to be able to use it ourselves, but as it turns out we don't need it, and we don't want to expose a public API unnecessarily, because we can never "take it back". Also the
MAGICenvironment variable works well forlibmagicif someone wants to control the magic database, so this API might not even be needed.The problem we were trying to solve to use the same magic database on different systems, but that turned out impossible to do, because the magic format breaks between every version, so the only way to use libmagic is to use the same version of the magic database, which is usually the one shipped with the system.