fix(handlers): fix edge cases in tar handler (empty name, too long name). #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me). tarfile python library does not perform any kind of defensive programming and will trigger OS level errors like ENAMETOOLONG trying to write files that have long names. This commit adds two checks to our safe implementation of tarfile so that we log the issue with a warning and skip the file. Note: tar files with such entries (long name, empty name) do not happen naturally and must be synthesized. That's why decided to skip them, in a similar fashion than GNU tar and 7zip.
e3krisztian
approved these changes
Apr 26, 2023
Contributor
e3krisztian
left a comment
e3krisztian
left a comment
There was a problem hiding this comment.
Eventually we should report these problems through report objects, not just logging.
This needs a public API change, as there is no reporting infrastructure for extractors, yet.
vlaci
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #563
tarfile python library does not perform any kind of defensive programming and will trigger OS level errors like ENAMETOOLONG trying to write files that have long names.
This commit adds two checks to our safe implementation of tarfile so that we log the issue with a warning and skip the file.
Note: tar files with such entries (long name, empty name) do not happen naturally and must be synthesized. That's why decided to skip them, in a similar fashion than GNU tar and 7zip.