Skip to content

improve tar handler to support sparse archives. #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2023
Merged

improve tar handler to support sparse archives. #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/integration/archive/tar/__input__/sparse.tar
View file
Open in desktop
Git LFS file not shown
3 changes: 3 additions & 0 deletions tests/integration/archive/tar/__output__/sparse.tar_extract/dummy1
View file
Open in desktop
Git LFS file not shown
3 changes: 3 additions & 0 deletions tests/integration/archive/tar/__output__/sparse.tar_extract/dummy2
View file
Open in desktop
Git LFS file not shown
3 changes: 3 additions & 0 deletions tests/integration/archive/tar/__output__/sparse.tar_extract/file1
View file
Open in desktop
Git LFS file not shown
3 changes: 3 additions & 0 deletions tests/integration/archive/tar/__output__/sparse.tar_extract/file2
View file
Open in desktop
Git LFS file not shown
3 changes: 1 addition & 2 deletions unblob/handlers/archive/tar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ def _get_end_of_last_tar_entry(file) -> int:
if last_member is None:
return -1

last_file_size = round_up(last_member.size, BLOCK_SIZE)
end_of_last_tar_entry = last_member.offset_data + last_file_size
end_of_last_tar_entry = tf.offset
try:
file.seek(end_of_last_tar_entry)
except SeekError:
Expand Down