Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eIDAS SAML extensions including SPType and RequestedAttribute/RequestedAttributes #520

Open
wants to merge 3 commits into
base: master
from

Conversation

@smarek
Copy link
Contributor

smarek commented Nov 27, 2019

I'm very new to Ruby programming, so I'm sorry for any default mistakes I could've made.

This proposal should provide ability of ruby-saml package to provide samlp:Extensions element as of eidas saml extensions xsd (included in PR) together with SPType (ServiceProviderType) indication and RequestedAttributes collection, directly in AuthRequest

This is based on EC eIDAS eID Profile specification (https://ec.europa.eu/cefdigital/wiki/display/CEFDIGITAL/eIDAS+eID+Profile), specifically eIDAS Message Format v1.2.pdf sections 2.3.2 and 4.1

To explain changes:

  • .gitignore - local vendor bundle should be ignored imo in ruby projects
  • formatting of code (proper indentation of lines and missing whitespaces) in authrequest.rb, settings.rb and request_test.rb ( i haven't found any coding style guidelines with the project, so i've applied default lint recommendations from RuboCop in my RubyMine IDE)
  • requested_attribute.rb - helper class to work with RequestedAttribute element, and provided that to REXML::Element.add_element
  • new param of Settings.initialize, to allow combination of keeping none/one-of/both security and extensions attributes
  • one test to validate, that code adds expected elements properly (this i plan to expand)
  • one test to validate, that settings provide :extensions symbol accessor

While I'm sorry for including changes, not directly relevant to matters, it would be very painful for me to format all my code manually, so please excuse that

…edAttributes
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 27, 2019

Coverage Status

Coverage increased (+0.09%) to 97.985% when pulling 33472e1 on smarek:eidas-saml-extensions into 449dd6b on onelogin:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 27, 2019

Coverage Status

Coverage increased (+0.03%) to 97.925% when pulling a0833fb on smarek:eidas-saml-extensions into 449dd6b on onelogin:master.

@smarek

This comment has been minimized.

Copy link
Contributor Author

smarek commented Nov 27, 2019

Only Travis job I consider possibly my fault is this: https://travis-ci.org/onelogin/ruby-saml/jobs/617734280
Could anyone please confirm that for me?

…crosoft cgg/2016 schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.