This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Feature/fp 87 #103
Merged
Feature/fp 87 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrKlis
suggested changes
May 2, 2023
| } | ||
|
|
||
| Widget _buildLoginWidget() { | ||
| final profileId = selectedProfileId; |
There was a problem hiding this comment.
Is there really a need for this variable? 🤔 You can use selectedProfileId
Contributor
Author
There was a problem hiding this comment.
Dart takes a similar approach to null safety as Kotlin does, so checking if a variable is null is not enough if it's mutable. Similar to why we use ?.let in Kotlin. In Dart however this check is enough when the variable is final.
PiotrKlis
approved these changes
May 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.