This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Don't expose internal api to end users #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use an internal api generated by Pigeon to communicate with the native side. This api should not be directly exposed to our users as we might want to do some extra processing. This commit makes that api private.
PiotrKlis
reviewed
May 25, 2023
| @SuppressWarnings({ "unused", "WeakerAccess" }) | ||
| public final class SecurityController { | ||
| public static final boolean rootDetection = false; | ||
| public static final boolean debugDetection = false; |
There was a problem hiding this comment.
you can also add
public static final boolean debugLogs = true;
if we want to make devs life easier. We do that in our example app https://github.com/onewelcome/example-app-android/blob/master/app/src/main/java/com/onegini/mobile/exampleapp/SecurityController.java
PiotrKlis
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use an internal api generated by Pigeon to communicate with the native side. This api should not be directly exposed to our users as we might want to do some extra processing.
This commit makes that api private.