Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

FP-90 Fix for the ClosePinAuthenticationEvent not fired #114

Merged
merged 1 commit into from
Jun 9, 2023
Merged

FP-90 Fix for the ClosePinAuthenticationEvent not fired #114

merged 1 commit into from
Jun 9, 2023

Conversation

@kfa-onewelcome
Copy link
Contributor

@kfa-onewelcome kfa-onewelcome commented Jun 9, 2023 •
edited
Loading

(when logged in)

Explanation:

cancelation worked for not logged user, as the delegate didFailToAuthenticateUser in LoginHandler calls loginHandler.handleDidFailToAuthenticateUser()

for logged user, the delegate didFailToRegister in AuthenticatorsHandler did not call it.

@kfa-onewelcome kfa-onewelcome requested a review from a team June 9, 2023 10:10
@aleknow aleknow merged commit f70e57a into develop Jun 9, 2023
@aleknow aleknow deleted the FP-90 branch June 9, 2023 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@aleknow aleknow aleknow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kfa-onewelcome @aleknow