Skip to content

Conversation

@shuaitseng
Copy link
Contributor

@shuaitseng shuaitseng commented Oct 28, 2025

Important

Add batchCreateAsync and getBatchCreateAsyncStatus endpoints to Tasks.php for asynchronous batch task operations, with documentation updates.

  • Endpoints:
    • Add batchCreateAsync endpoint for asynchronous batch task creation in Tasks.php.
    • Add getBatchCreateAsyncStatus endpoint for retrieving status of asynchronous batch task creation in Tasks.php.
  • Documentation:
    • Update CHANGELOG.md to include new endpoints in version 1.2.0.
    • Update README.md and README.es.md to reflect new Tasks operations: batchCreateAsync and getBatchCreateAsyncStatus.

This description was created by Ellipsis for d013803. You can customize this summary. It will automatically update as commits are pushed.

@ellipsis-dev
Copy link

ellipsis-dev bot commented Oct 28, 2025

PR Summary

This pull request adds two new endpoints to the Tasks resource in the PHP Onfleet SDK:

  1. batchCreateAsync - A POST endpoint on /tasks/batch-async that allows for asynchronous batch creation of tasks
  2. getBatchCreateAsyncStatus - A GET endpoint on /tasks/batch/:batchId that enables checking the status of an asynchronous batch operation

These additions enhance the SDK's capabilities for handling large batch operations in an asynchronous manner, which can improve performance for applications that need to create multiple tasks at once.

@ellipsis-dev
Copy link

ellipsis-dev bot commented Oct 28, 2025

⚠️ This PR modifies application logic but lacks adequate unit test coverage. Please ensure all new logic is tested.

I notice you've added two new API endpoints:

  • batchCreateAsync endpoint (POST method at '/tasks/batch-async')
  • getBatchCreateAsyncStatus endpoint (GET method at '/tasks/batch/:batchId')

These additions represent new application logic that should be verified with unit tests. Adding tests will help ensure these endpoints work as expected and continue to function correctly as the codebase evolves.

Could you please add appropriate unit tests for these new endpoints? Thank you!

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 99ecdea in 42 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/resources/Tasks.php:23
  • Draft comment:
    Consider aligning async endpoint paths for consistency. The async creation endpoint ('batchCreateAsync') uses '/tasks/batch-async', but its status endpoint ('getBatchCreateAsyncStatus') uses '/tasks/batch/:batchId'. For clarity, consider using a consistent pattern (e.g., '/tasks/batch-async/:batchId').
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_mcnIufBg6iyjhWOP

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 0d9515c in 55 seconds. Click for details.
  • Reviewed 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. README.es.md:90
  • Draft comment:
    Se han actualizado los endpoints para Tasks: se añade 'getBatchCreateAsync(id)' a GET y se cambia 'batch(obj)' por 'batchCreate(obj)' junto con la adición de 'batchCreateAsync(obj)' en POST. Asegúrate de que estos cambios reflejen correctamente la implementación de la API.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, describing changes made to the API endpoints. It does not provide any actionable feedback or suggestions for improvement. According to the rules, purely informative comments should be removed.
2. README.md:95
  • Draft comment:
    Se actualizaron los endpoints de Tasks en la tabla: se añade 'getBatchCreateAsync(id)' en GET y se reemplaza 'batch(obj)' por 'batchCreate(obj)' y se añade 'batchCreateAsync(obj)' en POST. Verifica que estos nombres coincidan con la implementación actual.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that the endpoint names match the current implementation. This falls under the rule of not asking the author to confirm or double-check things. Therefore, this comment should be removed.

Workflow ID: wflow_HzDZtLMfkI3uaZ5E

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Member

@gonzalogrisafi gonzalogrisafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed d013803 in 43 seconds. Click for details.
  • Reviewed 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. CHANGELOG.md:8
  • Draft comment:
    Changelog update for version 1.2.0 is clear and follows the established format. The new endpoints 'batchCreateAsync' and 'getBatchCreateAsyncStatus' are documented as expected. Ensure that the implementation, tests, and API docs are updated to match these changelog entries.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to ensure that the implementation, tests, and API docs are updated to match the changelog entries. This falls under the rule of not asking the PR author to ensure things are tested or updated, which is not allowed.

Workflow ID: wflow_VLzgOBXivgouKTDd

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@shuaitseng shuaitseng merged commit f9f474f into master Oct 28, 2025
2 checks passed
@shuaitseng shuaitseng deleted the add-batch-async branch October 28, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants