Skip to content

[Scheduled Txs] Remove redundant metric and add bucket to histogram #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2025
Merged

[Scheduled Txs] Remove redundant metric and add bucket to histogram #8045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b6e4fc
[Scheduled Txs] Remove redundant metric and increase number of histog…
j1010001 Oct 15, 2025
898654d
Merge branch 'master' into jan/improve-scheduled-txs-metrics
j1010001 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions module/metrics/execution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ type ExecutionCollector struct {
evmBlockTxCount prometheus.Histogram
evmBlockGasUsed prometheus.Histogram
callbacksExecutedCount prometheus.Histogram
callbacksExecutedTotal prometheus.Counter
callbacksProcessComputationUsed prometheus.Histogram
callbacksExecuteComputationLimits prometheus.Histogram
}
Expand Down Expand Up @@ -803,14 +802,7 @@ func NewExecutionCollector(tracer module.Tracer) *ExecutionCollector {
Subsystem: subsystemRuntime,
Name: "callbacks_executed_count",
Help: "the number of callbacks executed",
Buckets: prometheus.ExponentialBuckets(1, 2, 8),
}),

callbacksExecutedTotal: promauto.NewCounter(prometheus.CounterOpts{
Namespace: namespaceExecution,
Subsystem: subsystemRuntime,
Name: "callbacks_executed_total",
Help: "the total number of callbacks executed",
Buckets: prometheus.ExponentialBuckets(1, 2, 9),
}),

callbacksProcessComputationUsed: promauto.NewHistogram(prometheus.HistogramOpts{
Expand Down Expand Up @@ -921,7 +913,6 @@ func (ec *ExecutionCollector) ExecutionScriptExecuted(dur time.Duration, compUse
// ExecutionCallbacksExecuted reports callback execution metrics
func (ec *ExecutionCollector) ExecutionCallbacksExecuted(callbackCount int, processComputationUsed, executeComputationLimits uint64) {
ec.callbacksExecutedCount.Observe(float64(callbackCount))
ec.callbacksExecutedTotal.Add(float64(callbackCount))
ec.callbacksProcessComputationUsed.Observe(float64(processComputationUsed))
ec.callbacksExecuteComputationLimits.Observe(float64(executeComputationLimits))
}
Expand Down
Loading