Skip to content

Fix error styling #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix error styling #140

merged 1 commit into from
Apr 15, 2021

Conversation

@turbolent
Copy link
Member

Description

Make the error message a <pre> element, so that whitespace is preserved.

Fixes e.g.

Screen_Shot_2021-04-13_at_5 34 27_AM

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@vercel
Copy link

vercel bot commented Apr 13, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-playground/5R21fy9BhfY8xYtLGYQtsEDCgDBQ
✅ Preview: https://flow-playground-git-bastian-error-styling-onflow.vercel.app

@10thfloor 10thfloor merged commit 5a10857 into master Apr 15, 2021
10thfloor pushed a commit that referenced this pull request Apr 20, 2021
@turbolent @10thfloor
make error message a pre, so signification whitespace is not removed (#…
7bc7ff7 
…140)
10thfloor pushed a commit that referenced this pull request May 20, 2021
@turbolent
Add support for passing complex arguments to transactions and scripts (…
23ba454 
…#148)

* make error message a pre, so signification whitespace is not removed (#140)

* Test arguments on input via language server

* Bring back validation

* Add validation for arrays and imported types

Co-authored-by: Bastian Müller <bastian@axiomzen.co>
@bthaile bthaile deleted the bastian/error-styling branch May 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psiemens psiemens Awaiting requested review from psiemens

@MaxStalker MaxStalker Awaiting requested review from MaxStalker

1 more reviewer

@10thfloor 10thfloor 10thfloor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turbolent @10thfloor