Containerize server builds #24
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: Go Version Extraction Fails in Docker Tagging
The GO_REQUIRED variable, extracted from go.mod, can be empty if the grep regex ^go [0-9]+\.[0-9]+ fails to match Go versions with patch numbers (e.g., "go 1.21.5"), or if the go.mod file is missing/malformed. This results in an invalid Docker image tag golang:, causing the docker run command to fail with a cryptic error. The regex should be ^go [0-9]+\.[0-9]+(\.[0-9]+)?, and the script should handle extraction failures.
shared/build-server.sh#L27-L38
Was this report helpful? Give feedback by reacting with 👍 or 👎
juecd
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-server.shwas assuming a bit too much about a users local env. Instead we'll just run it in docker; we're still preferring this over multi-context builds due to limitations inkraft pkgTesting