fix: sidebar active state matching

- Change isActive to exact path matching instead of startsWith
- Add trailing slash removal to normalize function
- Add comprehensive tests for route functions

Author: onmax

packages/nimiq-vitepress-theme/src/lib/__tests__/route.test.ts

@@ -0,0 +1,78 @@
+import { describe, expect, it } from 'vitest'
+import { isActive, normalize } from '../route'
+
+describe('normalize', () => {
+  it('removes leading slash', () => {
+    expect(normalize('/path/to/page')).toBe('path/to/page')
+  })
+
+  it('removes trailing slash', () => {
+    expect(normalize('path/to/page/')).toBe('path/to/page')
+  })
+
+  it('removes .md extension', () => {
+    expect(normalize('path/to/page.md')).toBe('path/to/page')
+  })
+
+  it('removes .html extension', () => {
+    expect(normalize('path/to/page.html')).toBe('path/to/page')
+  })
+
+  it('removes index.md', () => {
+    expect(normalize('path/to/index.md')).toBe('path/to')
+  })
+
+  it('removes index.html', () => {
+    expect(normalize('path/to/index.html')).toBe('path/to')
+  })
+
+  it('removes leading index.md', () => {
+    expect(normalize('index.md')).toBe('')
+  })
+
+  it('removes hash fragments', () => {
+    expect(normalize('path/to/page#section')).toBe('path/to/page')
+  })
+
+  it('removes query parameters', () => {
+    expect(normalize('path/to/page?param=value')).toBe('path/to/page')
+  })
+
+  it('handles complex case', () => {
+    expect(normalize('/path/to/index.md#section')).toBe('path/to')
+  })
+})
+
+describe('isActive', () => {
+  it('returns false when matchPath is undefined', () => {
+    expect(isActive('path/to/page', undefined)).toBe(false)
+  })
+
+  it('returns true for exact path match', () => {
+    expect(isActive('nimiq-icons/explorer.html', '/nimiq-icons/explorer')).toBe(true)
+  })
+
+  it('returns false for non-matching paths', () => {
+    expect(isActive('nimiq-icons/explorer.html', '/nimiq-icons')).toBe(false)
+  })
+
+  it('returns true for index page matching module root', () => {
+    expect(isActive('nimiq-icons/index.html', '/nimiq-icons')).toBe(true)
+  })
+
+  it('returns true for exact match with extensions and slashes', () => {
+    expect(isActive('/path/to/page.md', 'path/to/page')).toBe(true)
+  })
+
+  it('returns false for partial matches that should not be active', () => {
+    expect(isActive('nimiq-icons-extended/page.html', '/nimiq-icons')).toBe(false)
+  })
+
+  it('handles hash fragments in match path', () => {
+    expect(isActive('path/to/page.md', '/path/to/page#section')).toBe(false) // simplified without browser hash check
+  })
+
+  it('normalizes paths before comparison', () => {
+    expect(isActive('path/to/index.md', '/path/to/')).toBe(true)
+  })
+})

packages/nimiq-vitepress-theme/src/lib/route.ts

@@ -11,17 +11,16 @@ export function isActive(currentPath: string, matchPath?: string): boolean {
   const normalizedCurrent = normalize(currentPath)
   const normalizedMatch = normalize(matchPath)
 
-  // Check if current path starts with the match path
-  if (!normalizedCurrent.startsWith(normalizedMatch))
-    return false
-
+  // If there's a hash in the match path, check it specifically
   const hashMatch = matchPath.match(HASH_RE)
-  if (hashMatch)
-    return (inBrowser ? location.hash : '') === hashMatch[0]
+  if (hashMatch) {
+    return normalizedCurrent === normalizedMatch && (inBrowser ? location.hash : '') === hashMatch[0]
+  }
 
-  return true
+  // For exact path matching, return true only if they are exactly the same
+  return normalizedCurrent === normalizedMatch
 }
 
 export function normalize(path: string): string {
-  return decodeURI(path).replace(HASH_OR_QUERY_RE, '').replace(INDEX_OR_EXT_RE, '$1')
+  return decodeURI(path).replace(HASH_OR_QUERY_RE, '').replace(INDEX_OR_EXT_RE, '$1').replace(/^\//, '').replace(/\/$/, '')
 }