Merged
Conversation
added 7 commits
December 28, 2018 09:12
Member
|
Hey everyone. We think this one is ready to go. Please try it out and give us some feedback. |
jamesaoverton
requested changes
Mar 1, 2019
Member
jamesaoverton
left a comment
There was a problem hiding this comment.
I'd like one change, please.
| + "This will rename two separate entities to have the same IRI, resulting in a merge." | ||
| + "\nDo you wish to continue? [y/N]", | ||
| lineNum, mappingsFile.getPath(), nextLine[1])); | ||
| String cont = s.nextLine(); |
Member
There was a problem hiding this comment.
I given this some thought, and I've decided that promtping for user input is a bad idea. ROBOT is meant to be used for automation. None of our other commands are interactive. make will get stuck forever if it hits this warning, which will surprise and annoy our users.
I think the better alternatives are:
- just log a warning
- add a
--fail-on-duplicates true/falseoption
jamesaoverton
requested changes
Mar 1, 2019
| o.addOption("m", "mappings", true, "table of mappings for renaming"); | ||
| o.addOption("r", "prefix-mappings", true, "table of prefix mappings for renaming"); | ||
| o.addOption("A", "add-prefix", true, "add a new prefix to ontology file header"); | ||
| o.addOption("f", "allow-duplicates", true, "allow two or more terms to be renamed to the same full IRI"); |
Member
There was a problem hiding this comment.
--allow-duplicates is a better name, but now “f” is not a good short name. Maybe “a” or “d”, or no short name.
jamesaoverton
approved these changes
Mar 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #293
The
--add-prefixoption makes sure that the prefix appears in the final output file, which does not happen if you just use--prefix.Right now, the
--fulland--partialfiles expect a header - should this be assumed? Or should we do no headers?