Add 'ontology' selection for remove and filter#452
Merged
jamesaoverton merged 8 commits intoontodev:masterfrom Mar 14, 2019
Merged
Add 'ontology' selection for remove and filter#452jamesaoverton merged 8 commits intoontodev:masterfrom
jamesaoverton merged 8 commits intoontodev:masterfrom
Conversation
added 3 commits
March 13, 2019 09:00
Contributor
|
Just to be annoying (sorry): Returns a new ontology y with the ontology annotations from x.owl and all axioms containing terms in terms.txt? |
Contributor
Author
|
No worries. Yes, that is correct! |
robot-command/src/main/java/org/obolibrary/robot/FilterCommand.java
Outdated
Show resolved
Hide resolved
Member
|
I think this is right. It has always bugged me that "imports" is handled in a special way, and now "ontology" is handled in a special way, but I don't see an alternative. Please include a test that addresses @matentzn's specific use case. |
Contributor
Author
|
Side note, @matentzn - I would also add the |
Contributor
|
Thanks @rctauber! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To remove or filter for the ontology annotations:
Returns a new ontology with only the ontology annotations from
x.owlReturns a copy of
x.owlwithout any ontology annotations.See #451