Skip to content

Conversation

@l1shen
Copy link
Collaborator

@l1shen l1shen commented May 15, 2025

No description provided.

@l1shen l1shen requested a review from leavesster as a code owner May 15, 2025 05:36
@l1shen l1shen requested review from BlackHole1 and Copilot May 15, 2025 05:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new host_endpoint property to the Context class to expose a host-accessible service URL.

  • Introduces host_endpoint property fetching OO_HOST_ENDPOINT from the environment.
  • Returns None when the variable is absent (e.g., in cloud environments).
Comments suppressed due to low confidence (2)

oocana/oocana/context.py:150

  • Add unit tests for the new host_endpoint property to verify both when OO_HOST_ENDPOINT is set and when it is unset.
def host_endpoint(self) -> str | None:

oocana/oocana/context.py:153

  • The environment variable OO_HOST_ENDPOINT is inconsistent with other host-related vars prefixed OOMOL_HOST_*. Consider aligning the prefix for consistency.
return os.getenv("OO_HOST_ENDPOINT", None)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@leavesster leavesster enabled auto-merge (squash) May 15, 2025 05:42
@leavesster leavesster disabled auto-merge May 15, 2025 05:46
@leavesster leavesster merged commit 84d86ba into oomol:main May 15, 2025
4 of 5 checks passed
@oomol-bot oomol-bot mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants