Skip to content

fix: add null safety checks for 10 undefined accesses (US-BF-003) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

fix: add null safety checks for 10 undefined accesses (US-BF-003) #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
463d24a
fix: add null safety checks for 10 undefined accesses (US-BF-003)
ooples Oct 16, 2025
9242412
fix: address Copilot review comments on null safety
ooples Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tools/advanced-caching/cache-analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,7 +887,7 @@ export class CacheAnalyticsTool extends EventEmitter {
0
);
const compressionSavings = operations.reduce(
(sum, op) => sum + (op.outputTokens - op.cachedTokens || 0),
(sum, op) => sum + (((op.outputTokens ?? 0) - (op.cachedTokens ?? 0)) || 0),
0
);

Expand Down
8 changes: 4 additions & 4 deletions src/tools/intelligence/anomaly-explainer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,18 +996,18 @@ export class AnomalyExplainer {
// Check for cyclical pattern
const seasonality = this.detectSeasonality(historicalData);

if (seasonality.detected && seasonality.strength && seasonality.strength > 0.6) {
if (seasonality?.detected && (seasonality?.strength ?? 0) > 0.6) {
causes.push({
id: 'rc-seasonal',
description: `Seasonality pattern detected with ${seasonality.period}ms period`,
description: `Seasonality pattern detected with ${seasonality.period ?? 0}ms period`,
probability: seasonality.strength,
evidence: [{
type: 'temporal',
description: `Regular pattern repeats every ${seasonality.period}ms`,
description: `Regular pattern repeats every ${seasonality.period ?? 0}ms`,
strength: seasonality.strength
}],
relatedMetrics: [anomaly.metric],
timeRange: { start: anomaly.timestamp - (seasonality.period || 0), end: anomaly.timestamp }
timeRange: { start: anomaly.timestamp - (seasonality.period ?? 0), end: anomaly.timestamp }
});
}

Expand Down