If commit ingestion is behind, the approved commits display can now crash the search page

[philc]

Now that we reference the Commit database object from the view ("db_commit.approved?"), if load the search page and a commit is shown which has been pulled, but has not had a corresponding record in the DB created for it, db_commit will be nil.

We've discussed this before. I think the general solution is to not render commits in the saved searches which do not also exist in the database.

[philc]

My dev barkeep install was in this state for about 10s as I pulled in a bunch of new commits and the DB insertions were happening.

[cespare]

Yeah, this is worse manifestation of the existing bug (previously you would just get "no such commit" if you clicked on one of those un-ingested commits).