Skip to content

Minor fix DocIndexRetriever test #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2024
Merged

Minor fix DocIndexRetriever test #1266

merged 3 commits into from
Dec 19, 2024

Conversation

@Spycsh
Copy link
Collaborator

@Spycsh Spycsh commented Dec 18, 2024 •
edited
Loading

Description

fix missing gaudi in the service name
increase waiting time to ensure the service is on for warmup

Issues

#1263

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

na

Tests

na

@github-actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@Spycsh Spycsh requested a review from chensuyue December 18, 2024 07:17
@Spycsh Spycsh requested a review from ftian1 as a code owner December 19, 2024 04:05
@lkk12014402
Copy link
Collaborator

lkk12014402 commented Dec 19, 2024 •
edited
Loading

since we remove ChatCompletionRequest for embedding_tei microservice, we should remove related ut that uses it. see this commit 695f6c0

@Spycsh
Copy link
Collaborator Author

Spycsh commented Dec 19, 2024

To keep the component OpenAI compatible, following this pr, we need to deprecate the hardcoded path for mega and leave the equivalent work to align_inputs/align_outputs for alignment.

@Spycsh Spycsh merged commit 3b9e55c into opea-project:main Dec 19, 2024
14 checks passed
Spycsh added a commit that referenced this pull request Dec 19, 2024
@Spycsh
Revert "Minor fix DocIndexRetriever test (#1266)"
bd26c76 
This reverts commit 3b9e55c.
@Spycsh Spycsh mentioned this pull request Dec 19, 2024
Merged
4 tasks
@Spycsh Spycsh deleted the fix_1218 branch December 19, 2024 04:34
@joshuayao joshuayao linked an issue Dec 20, 2024 that may be closed by this pull request
[Bug] 2 examples failed with aiohttp.client_exceptions.ContentTypeError in nightly test #1263
Closed
6 tasks
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Dec 20, 2024
@Spycsh
Minor fix DocIndexRetriever test (opea-project#1266)
62763f2 
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkk12014402 lkk12014402 lkk12014402 approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@letonghan letonghan letonghan approved these changes

@chensuyue chensuyue Awaiting requested review from chensuyue

@ftian1 ftian1 Awaiting requested review from ftian1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] 2 examples failed with aiohttp.client_exceptions.ContentTypeError in nightly test

4 participants

@Spycsh @lkk12014402 @lvliang-intel @letonghan