Skip to content

[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milvus as Vector DB #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 21, 2025
Merged

[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milvus as Vector DB #1639

merged 8 commits into from
Apr 21, 2025

Conversation

@srajabos
Copy link
Contributor

@srajabos srajabos commented Mar 8, 2025

[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milvus as Vector DB

Fixes #900

Description

Create a version of MultimodalQnA example with Zilliz/Milvus as Vector DB

Issues

#900

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ *] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • [* ] Others (enhancement, documentation, validation, etc.)

Dependencies

na

Tests

E2E tests are tested

@github-actions
Copy link

github-actions bot commented Mar 8, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

@srajabos srajabos mentioned this pull request Mar 8, 2025
Closed
@srajabos @skavulya
[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milv…
22ac197 
…us as Vector DB

Fixes opea-project#900
Co-authored-by: Jaini, Pallavi <pallavi.jaini@intel.com>
Co-authored-by: Kavulya, Soila <soila.kavulya@intel.com>
Signed-off-by: Ghosh, Soumyadip <soumyadip.ghosh@intel.com>
Signed-off-by: Piroozan, Nariman <nariman.piroozan@intel.com>

Signed-off-by: Shifani Rajabose <srajabose@habana.ai>
letonghan
letonghan reviewed Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@letonghan letonghan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srajabos , please fix the E2E test failure and add test scripts for compose_milvus on xeon and gaudi like your another PR.
Thanks!

@letonghan letonghan added the OPEAHack Issue created for OPEA Hackathon label Mar 17, 2025
chensuyue
chensuyue reviewed Mar 17, 2025
View reviewed changes
pallavijaini0525 and others added 2 commits April 2, 2025 15:23
@pallavijaini0525
Added the test case for the xeon
097d9e8 
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
@yinghu5
Merge branch 'main' into bug-900
e537d65
@yinghu5 yinghu5 requested review from xiguiw and yinghu5 April 10, 2025 01:59
@yinghu5
Copy link
Collaborator

yinghu5 commented Apr 10, 2025

Hi @srajabos one CI failed, please take care

@Spycsh
Copy link
Collaborator

Spycsh commented Apr 15, 2025

@srajabos the video frame is unexpectedly truncated https://github.com/opea-project/GenAIComps/blob/main/comps/dataprep/src/integrations/milvus_multimodal.py#L177 and the truncated image base64 string cannot be handled correctly by LVM. Please check whether that hard limit 65535 is a must.

@pallavijaini0525
Copy link
Collaborator

pallavijaini0525 commented Apr 15, 2025

@Spycsh @letonghan -> https://github.com/opea-project/GenAIComps/blob/main/comps/dataprep/src/integrations/milvus_multimodal.py#L177 -> There is a limitation for the metadata values , that is the reason for adding that.

The real embeddings and texts are added to the database. https://github.com/opea-project/GenAIComps/blob/main/comps/dataprep/src/integrations/milvus_multimodal.py#L178

Will metadata truncation will also affect?

@yinghu5 yinghu5 mentioned this pull request Apr 16, 2025
Closed
letonghan
letonghan approved these changes Apr 21, 2025
View reviewed changes
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lvliang-intel lvliang-intel merged commit 338f814 into opea-project:main Apr 21, 2025
17 checks passed
yongfengdu pushed a commit to yongfengdu/GenAIExamples that referenced this pull request May 8, 2025
@srajabos @yongfengdu
[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milv…
3066dc8 
…us as Vector DB (opea-project#1639)

Signed-off-by: Shifani Rajabose <srajabose@habana.ai>
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
@srajabos @chyundunovDatamonsters
[Bug: 900] Create a version of MultimodalQnA example with Zilliz/Milv…
7920799 
…us as Vector DB (opea-project#1639)

Signed-off-by: Shifani Rajabose <srajabose@habana.ai>
Signed-off-by: Pallavi Jaini <pallavi.jaini@intel.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chensuyue chensuyue chensuyue left review comments

@pallavijaini0525 pallavijaini0525 pallavijaini0525 left review comments

@lkk12014402 lkk12014402 lkk12014402 approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@letonghan letonghan letonghan approved these changes

@tileintel tileintel Awaiting requested review from tileintel

@yinghu5 yinghu5 Awaiting requested review from yinghu5

@xiguiw xiguiw Awaiting requested review from xiguiw

Assignees

No one assigned

Labels

OPEAHack Issue created for OPEA Hackathon v1.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a version of MultimodalQnA example with Zilliz/Milvus as Vector DB

9 participants

@srajabos @yinghu5 @Spycsh @pallavijaini0525 @lkk12014402 @chensuyue @lvliang-intel @letonghan @xiguiw