Fixes for MultimodalQnA with the Milvus vector db #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with MultimodalQnA’s integration with the Milvus vector database backend. It updates the docker-compose configuration to include missing environment variables, corrects the collection name in the README, and adds documentation regarding unsupported audio captions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MultimodalQnA/docker_compose/intel/cpu/xeon/compose_milvus.yaml | Added missing dataprep endpoints (GET and DELETE) to support file operations |
| MultimodalQnA/docker_compose/intel/cpu/xeon/README.md | Updated the collection name to "LangChainCollection" and added a note about unsupported audio captions |
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
ashahba
reviewed
Apr 21, 2025
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
louie-tsai
approved these changes
Apr 21, 2025
chensuyue
pushed a commit
that referenced
this pull request
Apr 25, 2025
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com> (cherry picked from commit e10e6dd)
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
letonghan
pushed a commit
that referenced
this pull request
Sep 17, 2025
Signed-off-by: chensuyue <suyue.chen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues when running MultimodalQnA with the Milvus vector database backend:
export COLLECTION_NAME=mm_rag_milvusas the README instructions state does not work. The test script instead usesexport COLLECTION_NAME="LangChainCollection", and this does work, so I updated the README to match.Issues
#1858
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Manually tested based on the README instructions. Existing tests did not fail, since the env setup in the script differed from the README.