update default model to resolve the vllm/model_executor issue #1985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the default model configuration to resolve the vllm/model_executor issue.
- Added an environment variable for HF_TOKEN in the Docker Compose file
- Assigned HF_TOKEN the same value as HUGGINGFACEHUB_API_TOKEN to meet service requirements
Files not reviewed (1)
- DocSum/docker_compose/intel/set_env.sh: Language not supported
| http_proxy: ${http_proxy} | ||
| https_proxy: ${https_proxy} | ||
| HUGGINGFACEHUB_API_TOKEN: ${HUGGINGFACEHUB_API_TOKEN} | ||
| HF_TOKEN: ${HUGGINGFACEHUB_API_TOKEN} |
There was a problem hiding this comment.
Please add an inline comment clarifying the need for HF_TOKEN alongside HUGGINGFACEHUB_API_TOKEN, explaining if they target different service behaviors or provide backward compatibility for the vllm/model_executor.
Signed-off-by: chensuyue <suyue.chen@intel.com>
Collaborator
Author
|
gaudi test failed with known issue opea-project/GenAIComps#1725 |
lvliang-intel
approved these changes
May 22, 2025
XuehaoSun
approved these changes
May 22, 2025
Contributor
|
Workaround indeed. Just changing the default is not going to fix issue user is going to have when she tries to use some other model. I.e. this issue will need more investigation... |
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
…roject#1985) Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update default model to resolve the vllm/model_executor issue.
Issues
workaround for opea-project/GenAIComps#1719
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.