Skip to content

Conversation

@chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jun 12, 2025

Description

[CICD enhance] SearchQnA run CI with latest base image, group logs in GHA outputs.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <suyue.chen@intel.com>
Copilot AI review requested due to automatic review settings June 12, 2025 13:56
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances CI by dynamically using the latest base image and grouping test script logs in GitHub Actions for improved readability.

  • Standardize and shallow-clone the GenAIComps repo, print its commit SHA, and build a tagged base image in each CI script.
  • Introduce IMAGE_REPO/BASE_TAG args in build definitions and update the Dockerfile’s FROM to use them.
  • Wrap key test script phases in ::group::…::endgroup:: markers and replace interactive prune with a non-interactive one.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SearchQnA/tests/test_compose_vllm_on_rocm.sh Added branch arg, shallow clone, commit echo, build image, CI grouping, non-interactive prune
SearchQnA/tests/test_compose_on_xeon.sh Standardized clone/build, added CI grouping markers, updated prune
SearchQnA/tests/test_compose_on_rocm.sh Standardized clone/build, redirected logs to include stderr, added CI grouping markers, updated prune
SearchQnA/tests/test_compose_on_gaudi.sh Standardized clone/build, added CI grouping markers, updated prune
SearchQnA/docker_image_build/build.yaml Passed IMAGE_REPO and BASE_TAG as build args
SearchQnA/Dockerfile Introduced ARG IMAGE_REPO and updated FROM to use it
Comments suppressed due to low confidence (2)

SearchQnA/tests/test_compose_vllm_on_rocm.sh:1

  • [nitpick] Consider adding set -euo pipefail after the shebang to ensure the script exits on errors, treats unset variables as failures, and catches pipeline errors early.
#!/usr/bin/env bash

SearchQnA/tests/test_compose_vllm_on_rocm.sh:109

  • [nitpick] The grouping logic (::group::/::endgroup::) is duplicated across multiple test scripts. Consider extracting these into a shared CI utility or sourceable script to reduce repetition and simplify future updates.
echo "::group::stop_docker"

@chensuyue chensuyue merged commit 66540e6 into main Jun 13, 2025
20 checks passed
@chensuyue chensuyue deleted the suyue/opt3 branch June 13, 2025 06:58
alexsin368 pushed a commit to alexsin368/GenAIExamples that referenced this pull request Aug 13, 2025
… GHA outputs. (opea-project#2073)

Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants